Add support for ssl in v3 #1175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
chore
aphralG
reviewed
Jul 21, 2025
internal/collector/nginxossreceiver/internal/scraper/stubstatus/stub_status_scraper_tls_test.go
Outdated
Show resolved
Hide resolved
aphralG
reviewed
Jul 21, 2025
internal/collector/nginxossreceiver/internal/scraper/stubstatus/stub_status_scraper_tls_test.go
Outdated
Show resolved
Hide resolved
aphralG
reviewed
Jul 21, 2025
internal/collector/nginxossreceiver/internal/scraper/stubstatus/stub_status_scraper_tls_test.go
Outdated
Show resolved
Hide resolved
aphralG
reviewed
Jul 21, 2025
internal/collector/nginxossreceiver/internal/scraper/stubstatus/stub_status_scraper_tls_test.go
Outdated
Show resolved
Hide resolved
aphralG
reviewed
Jul 21, 2025
internal/collector/nginxossreceiver/internal/scraper/stubstatus/stub_status_scraper_tls_test.go
Outdated
Show resolved
Hide resolved
aphralG
reviewed
Jul 21, 2025
internal/collector/nginxossreceiver/internal/scraper/stubstatus/stub_status_scraper_tls_test.go
Show resolved
Hide resolved
dhurley
reviewed
Jul 21, 2025
internal/collector/nginxossreceiver/internal/scraper/stubstatus/stub_status_scraper.go
Outdated
Show resolved
Hide resolved
internal/collector/nginxossreceiver/internal/scraper/stubstatus/stub_status_scraper.go
Outdated
Show resolved
Hide resolved
spencerugbo
approved these changes
Jul 22, 2025
craigell
approved these changes
Jul 22, 2025
dhurley
approved these changes
Jul 22, 2025
aphralG
reviewed
Jul 22, 2025
internal/collector/nginxossreceiver/internal/scraper/stubstatus/stub_status_scraper_tls_test.go
Show resolved
Hide resolved
internal/collector/nginxossreceiver/internal/scraper/stubstatus/stub_status_scraper_tls_test.go
Outdated
Show resolved
Hide resolved
internal/collector/nginxossreceiver/internal/scraper/stubstatus/stub_status_scraper_tls_test.go
Outdated
Show resolved
Hide resolved
john-david3
approved these changes
Jul 22, 2025
aphralG
approved these changes
Jul 22, 2025
* update go verion and golangci-lint * add paths for NAP upon instance discovery * use variable for NAP directory path * add paths when creating NAP instance * add nap paths by default, update agent config during upgrade * add nap by default * nap paths to default agent configuration * add back log message * only add config directory /etc/app_protect * update preinstall.sh * update default config * remove blank line --------- Co-authored-by: Aphral Griffin <a.griffin@f5.com>
Fixing Unit Test failling in main branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to that issue using one of the supported keywords here in this description (not in the title of the PR).
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentmake install-toolsand have attached any dependency changes to this pull requestREADME.md)